Preserve unsigned build artifacts in dry run workflow#171
Merged
Conversation
The dry run workflow now uploads the built .dmg file as an artifact, making it available for inspection and testing on every merge to main. The artifact is retained for 30 days.
Keep the unsigned DMG artifacts for one week instead of 30 days to manage storage.
The artifact name now includes the first 8 characters of the commit SHA, making it easier to identify which build produced which artifact.
The .dmg file is now renamed to MacDown-3000-build-${commit-sha}.dmg before uploading, making the actual artifact filename include the commit identifier.
For the dry run, we archive the .app bundle as a tar.gz instead of creating a full DMG. This is simpler and sufficient for preserving the unsigned build for testing.
The macos-14 runner has zip utility built-in, and it's more user-friendly for macOS users than tar.gz.
Ensure the zip command succeeds with explicit error exit, and display the archive size for verification.
Contributor
Code Coverage ReportCurrent Coverage: 41.12% Coverage Details (Summary) |
- Artifact name no longer duplicates the .zip extension - Archive and upload steps only run on push events (merges to main), not pull requests
Remove the redundant push event trigger. Tests will now run only on pull requests to main/develop branches, where they serve as the review checkpoint. The build-release.yml dry run already validates that the build works on merge to main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The dry run workflow (build-release.yml) now preserves the unsigned app bundle as a zip artifact on every merge to main, making it available for testing and inspection.
Changes
MacDown-3000-build-${commit-sha}.zipMotivation
Previously, the dry run workflow only uploaded logs on failure. Now successful builds are preserved as downloadable artifacts, allowing easy access to unsigned test builds without rebuilding locally.
Testing
The workflow runs on every push to main and pull request to main. Verify by checking the artifacts in a workflow run.