Address issue #32: Fix Open Recent menu on macOS Sonoma#119
Merged
Conversation
Added required macOS folder permission keys to Info.plist: - NSDesktopFolderUsageDescription - NSDocumentsFolderUsageDescription - NSDownloadsFolderUsageDescription These permission keys are required for macOS Sonoma (14.x+) to display permission dialogs that allow the app to track recently opened files. Without these keys, the "Open Recent" menu appears blank or shows "document (null) could not be opened" errors. The descriptions inform users that MacDown needs folder access to track recently opened files. This is a standard macOS privacy pattern. Changes are backward compatible - older macOS versions ignore these keys. Related to #32
Contributor
Code Coverage ReportCurrent Coverage: 39.85% Coverage Details (Summary) |
Owner
Author
|
I couldn't reproduce this bug on Sequoia, and I don't have access to Sonoma, but I'm going to merge anyway and hope for the best! |
|
Critical Tests passed for MacDown-3000.0.0-beta.2 on Ventura 13.6.9. No dialogs requesting permissions appeared. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the "Open Recent" menu on macOS Sonoma (14.x+) by adding required folder permission description keys to Info.plist.
Problem
The "Open Recent" menu was completely broken on macOS Sonoma:
Root Cause
macOS Sonoma requires specific permission keys in Info.plist to access protected folders (Desktop, Documents, Downloads). Without these keys, the consent dialogue never appears and the app cannot track recently opened files.
Solution
Added three permission description keys to
MacDown/MacDown-Info.plist:Changes
MacDown/MacDown-Info.plist(added 6 lines)User Impact
When users first open a file from Desktop/Documents/Downloads after this update:
Backward Compatibility
✅ These keys are ignored on older macOS versions - no compatibility issues
Related Issue
Related to #32
Testing
CI Results
✅ Build succeeded on macOS 14 (Sonoma)
✅ All tests passed
Code Review
✅ Reviewed by Chico - Approved with no critical issues
Manual Testing Plan
Critical Test Cases
Permission Dialog Appearance
Permission Granted
Subsequent Files (No Dialog)
Multiple Folders
Clear Menu
Edge Cases to Test
Full manual testing plan available in the Zeppo consultation (comprehensive test suite covering 18+ test cases including setup, core functionality, edge cases, and regression tests).
Minimum Testing (15-20 minutes)
Review Notes
Architectural Guidance (Groucho)
Code Review (Chico)
Documentation (Harpo)
Testing (Zeppo)
Deployment Considerations
Release Notes
Suggest including in release notes:
Support Considerations
Ready for review and manual testing on macOS Sonoma.