Fix lookupUserId to handle 'self' keyword#104
Merged
Conversation
Now that 'self' resolves via GetViewerId instead of LookupUser, update the test mocks accordingly.
Owner
|
seems reasonable, i'm ok with someone using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
--assignee selffails with:Root Cause
The code in
issue-create.tsuses"self"as the keyword for auto-assigning to the current user (lines 184, 389, 648), butlookupUserId()only checks for"@me".When
"self"is passed, it falls through to the user search query which looks for a user literally named "self" - which doesn't exist.Fix
Add
"self"as an alias alongside"@me"inlookupUserId():Now both
--assignee selfand--assignee @mework correctly.