Adaptable frequency referencing for phantoms#732
Merged
HJZollner merged 4 commits intoschorschinho:developfrom Apr 25, 2024
Merged
Adaptable frequency referencing for phantoms#732HJZollner merged 4 commits intoschorschinho:developfrom
HJZollner merged 4 commits intoschorschinho:developfrom
Conversation
Range check/adjustment of frequency limits failed due to incorrect variable name
Adaptable referencing for phantoms which may not include the typical reference singlets, and may include a 0 ppm reference.
Collaborator
|
Thanks @alexcraven |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current frequency referencing assumes the presence of Cr and Cho, or NAA singlets. This is fine for healthy brains and brain-like phantoms (eg, BRAINO solution), but problematic for non-brain-like phantoms.
This update adds a function,
osp_PhantomReferencing, which checks for the presence of these major singlets in the expected constellation before trying to reference to them. It also checks for a 0 ppm reference (DSS/TSP) and uses that if the major peaks are not present. If neither option is available, no further referencing is attempted (which is preferable to incorrectly referencing to an unknown other singlet)