Add printing receive command as a qr code with new --qrcode flag#591
Closed
lukenvn wants to merge 4 commits intoschollz:mainfrom
Closed
Add printing receive command as a qr code with new --qrcode flag#591lukenvn wants to merge 4 commits intoschollz:mainfrom
lukenvn wants to merge 4 commits intoschollz:mainfrom
Conversation
added 3 commits
August 30, 2023 11:53
… only receive code as qr only
Owner
|
thanks for the contribution! how do you use this feature? do you receive things are your phone? code looks great. |
Author
Sorry for my late response. Ya on the phone I will use the qr scanner to get the code, then paste it to the crocgui recevie tab, just simple like that. |
|
Hello, I see it is not in the last version, can you merge again ? Thank you |
Closed
Owner
|
@jpph conflicts need to be resolved. go ahead and rebase this yourself, or checkout the commits themselves (not too many lines) and create a new pr with it. |
|
Sorry I do not have the knowledge and capabilities to do so... if too much work you can leave it closed... Thank you :-) |
Merged
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi guys,
This pull request adds a new feature to the Croc software, allowing users to display the receive command as a QR code by using the --qrcode flag. This feature enhances the usability and convenience of Croc by providing an easily scannable QR code representation of the receive command.I also plan to add scan qrcode feature in croc android soon.
Changes Made:
Benefits:
P/s: This is my first time of using go lang so Im not sure what i'm is in good practice, so please let me know if i should improve something. Thank you in advanced .