fix(install): add BusyBox compatibility fallback#1032
Merged
schollz merged 1 commit intoschollz:mainfrom Dec 23, 2025
Merged
Conversation
Fixes schollz#1027 BusyBox's install command does not support -C (compare), -b (backup), or -S (backup suffix) flags. When these flags fail, fall back to: 1. Simple 'install -m 755' command 2. If install completely unavailable, use cp + chmod This allows croc to be installed in minimal Docker containers like debian:stable-slim, netshoot, alpine, etc. using the bash installer.
|
Not bad |
Contributor
Author
|
@schollz Thanks for maintaining this great project! I've tested this fix on multiple minimal Docker containers (debian:stable-slim, alpine, netshoot) and it works well. Please let me know if you'd like any changes or additional testing. Happy to adjust anything! 🙏 |
|
I think it dont need any changes) |
Contributor
Author
|
@ToshmatovDeveloper Thanks for the review and feedback! Really appreciate it. |
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1027
Summary
Add fallback mechanism for BusyBox compatibility in the install script.
Problem
BusyBox's
installcommand (used in debian:stable-slim, netshoot, alpine, etc.) does not support-C(compare),-b(backup), or-S(backup suffix) flags, causing the install to fail with:Solution
-C -b -S)install -m 755cp+chmod 755Changes
install_file_linux()insrc/install/default.txt2>/dev/nullto suppress errors from unsupported flagscp/chmodfallback as last resortTesting