feat(instance): support snapshot based instance#3787
Merged
remyleone merged 5 commits intoscaleway:masterfrom Jul 1, 2024
Merged
feat(instance): support snapshot based instance#3787remyleone merged 5 commits intoscaleway:masterfrom
remyleone merged 5 commits intoscaleway:masterfrom
Conversation
3 tasks
bdc9f1a to
7f521e5
Compare
Codelax
reviewed
May 20, 2024
| serverType *instance.ServerType | ||
| ) | ||
| if args.Image != "none" { | ||
| getImageResponse, err := apiInstance.GetImage(&instance.GetImageRequest{ |
Member
There was a problem hiding this comment.
getImageResponse is shadowing the one created in previous context.
Suggested change
| getImageResponse, err := apiInstance.GetImage(&instance.GetImageRequest{ | |
| var err error | |
| getImageResponse, err = apiInstance.GetImage(&instance.GetImageRequest{ |
| } | ||
|
|
||
| serverType := getServerType(apiInstance, serverReq.Zone, serverReq.CommercialType) | ||
| serverType := getServerType(apiInstance, serverReq.Zone, serverReq.CommercialType) |
Member
There was a problem hiding this comment.
serverType shadows the one created in previous context
Suggested change
| serverType := getServerType(apiInstance, serverReq.Zone, serverReq.CommercialType) | |
| serverType = getServerType(apiInstance, serverReq.Zone, serverReq.CommercialType) |
Contributor
Author
There was a problem hiding this comment.
Oops thanks a lot. Missed that. That should explain the failing CI.
7f521e5 to
ad04273
Compare
ad04273 to
7ea13bb
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3787 +/- ##
==========================================
- Coverage 75.45% 69.25% -6.21%
==========================================
Files 202 288 +86
Lines 44323 54603 +10280
==========================================
+ Hits 33444 37814 +4370
- Misses 9653 15256 +5603
- Partials 1226 1533 +307 ☔ View full report in Codecov by Sentry. |
This PR allow users to create an instance from a snapshot directly without creating an image. It's already supported by the APIs. Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
082db02 to
fc68b94
Compare
Contributor
Author
|
@remyleone do you want me to rebase on master? |
remyleone
approved these changes
Jul 1, 2024
Member
|
Thanks a lot @tormath1 for your contribution :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
In this PR I tried to allow the CLI to deploy an instance directly from a snapshot without calling the marketplace API.
Community Note
Release note for CHANGELOG: