Fix "Missing argument results in java.lang.VerifyError"#24938
Fix "Missing argument results in java.lang.VerifyError"#24938lihaoyi wants to merge 2 commits intoscala:mainfrom
Conversation
|
Oops, we were working on the same issue #24983 object Baz extends {
def defaultValue$1: Baz = Baz.E1 // lifted by-name method (ExprType)
val arg1$1: Int = Foo.<init>$default$2[Baz]
new Foo[Baz](defaultValue$1, arg1$1, arg2 = 2)
} { ... }↓ object Baz extends {
// defaultValue$1 removed
...
new Foo[Baz](Baz$$superArg$1()(arg1$1), ...)
} { ...
private <static> def Baz$$superArg$1()(arg1$1: Int): () ?=> Baz =
() => Baz.E1
}instead of object Baz extends {
def defaultValue$1: Baz = Baz.E1
...
new Foo[Baz](Baz$$superArg$1()(defaultValue$1, arg1$1), ...)
} { ...
private <static> def Baz$$superArg$1()(defaultValue$1: => Baz, ...): () ?=> Baz =
() => defaultValue$1
}A difference is, while my change inlines synthetic methods with sym.is(Synthetic) && sym.is(Method) && sym.info.isInstanceOf[ExprType]you're attempting to inline when the body has a reference to |
|
@tanishiking please go ahead and take ideas from this PR! This is largely Claude's work haha, I don't actually know what's happening (which is why I haven't manage to fix the CI failures...) |
|
given that CI fails + the new LLM policy, @tanishiking do you want to keep working on this or your PR to fix the issue? |
|
@SolalPirelli Sure, I was struggling to fix the same issue at #25157, gonna get back to this when I have time 👍 |
|
closing for #25502 :) |
Attempts to fix #24201, vibe coded