Skip to content

Avoid deprecated URL ctor in scaladoc#17426

Merged
ckipp01 merged 1 commit intoscala:mainfrom
som-snytt:tweak/scaladoc-jdk20
May 8, 2023
Merged

Avoid deprecated URL ctor in scaladoc#17426
ckipp01 merged 1 commit intoscala:mainfrom
som-snytt:tweak/scaladoc-jdk20

Conversation

@som-snytt
Copy link
Copy Markdown
Contributor

@som-snytt som-snytt commented May 6, 2023

Follow-up to #17403 includes scaladoc.

@ckipp01
Copy link
Copy Markdown
Member

ckipp01 commented May 8, 2023

Screenshot 2023-05-08 at 09 13 07

@romanowski really really really approves this 😆

ckipp01
ckipp01 approved these changes May 8, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@ckipp01 ckipp01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 looks good, thanks @som-snytt.

@ckipp01 ckipp01 merged commit 830230f into scala:main May 8, 2023
@som-snytt som-snytt deleted the tweak/scaladoc-jdk20 branch May 8, 2023 08:59
@romanowski
Copy link
Copy Markdown
Contributor

romanowski commented May 8, 2023

@romanowski really really really approves this 😆

It is testament to the GitHub UI :) As they say 3 4 times the charm :D

@som-snytt
Copy link
Copy Markdown
Contributor Author

som-snytt commented May 8, 2023

@ckipp01 I'm curious how this PR was merged. Is it without a merge commit, but a rebase and merge? I see the difference because git branch -d won't work locally. I haven't had coffee yet this morning.

@ckipp01
Copy link
Copy Markdown
Member

ckipp01 commented May 8, 2023

@ckipp01 I'm curious how this PR was merged. Is it without a merge commit, but a rebase and merge? I see the difference because git branch -d won't work locally. I haven't had coffee yet this morning.

I used whatever the default was, I think "Squash and merge". Maybe you already fetched upstream and synced? And since you deleted the branch here, it's deleted locally as well? Or do you mean it won't allow you to delete it locally?

@Kordyjan Kordyjan added this to the 3.3.1 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romanowski romanowski romanowski approved these changes

@ckipp01 ckipp01 ckipp01 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.3.1

Development

Successfully merging this pull request may close these issues.

4 participants

@som-snytt @ckipp01 @romanowski @Kordyjan