ordinal: drop unchecked with sealed abstract skips#13414
ordinal: drop unchecked with sealed abstract skips#13414dwijnand wants to merge 4 commits intoscala:masterfrom
Conversation
d50da57 to
69870ce
Compare
|
This is failing because the "tricksier" variation in the second half of tests/patmat/t6146.scala is now emitting an unreachable warning. But first: I found that the definition order of the T1/T2 traits, the O1/O2 objects and the external child In that "emit deferred reachability warnings" PR, in turn, I discovered that my fix for unboxed/boxed primitives (#13290) wasn't right, the unreachable ones were just not getting reported. So now I need to fix |
In the `ordinal` method, drop the use of `@unchecked` by skipping children that are sealed traits or sealed abstract classes and don't have any anonymous subclasses. The `@unchecked` I added in ee5a82f. In a PR to specifically with reachability I started similar warnings in `ordinal` (this was before adding `@unchecked` was merged) so I'm hoping with this patch to avoid the false positives properly.
d35d4dc to
2b37f03
Compare
|
Fix that, and something else breaks. Taking a break from this. |
In the
ordinalmethod, drop the use of@uncheckedby skipping childrenthat are sealed traits or sealed abstract classes and don't have any
anonymous subclasses.
The
@uncheckedI added in ee5a82f. In aPR to do specifically with reachability I started seeing similar warnings in
ordinal(this was before adding@uncheckedwas merged) so I'm hopingwith this patch to avoid the false positives properly.