Skip to content

[2.12] Upgrade scala-parser-combinators to latest 2.0.0#9744

Closed
mkurz wants to merge 1 commit intoscala:2.12.xfrom
mkurz:scala-parser-combinators-2.0.0
Closed

[2.12] Upgrade scala-parser-combinators to latest 2.0.0#9744
mkurz wants to merge 1 commit intoscala:2.12.xfrom
mkurz:scala-parser-combinators-2.0.0

Conversation

@mkurz
Copy link
Contributor

@mkurz mkurz commented Aug 30, 2021

Same story as in #9743: If a sbt-plugin bumps its scala-parser-combinators dependency to 2.0.0, and later you add that sbt-plugin to your project/plugins.sbt you will not be able to access the sbt console without adding ThisBuild / libraryDependencySchemes += "org.scala-lang.modules" %% "scala-parser-combinators" % VersionScheme.Always to project/plugins.sbt.
An example would be sbt-native-packager: https://github.com/sbt/sbt-native-packager/blob/e72f2f45b8cab5881add1cd62743bfc69c2b9b4d/build.sbt#L43

@scala-jenkins scala-jenkins added this to the 2.12.15 milestone Aug 30, 2021
@mkurz mkurz changed the title Upgrade scala-parser-combinators to latest 2.0.0 [2.12] Upgrade scala-parser-combinators to latest 2.0.0 Aug 30, 2021
@SethTisue SethTisue added the release-notes worth highlighting in next release notes label Aug 30, 2021
@SethTisue SethTisue marked this pull request as draft August 30, 2021 20:25
@SethTisue
Copy link
Member

marking as draft for now, as we discuss on #9743

@mkurz
Copy link
Contributor Author

mkurz commented Aug 31, 2021

Closing, see #9743 (comment)

@mkurz mkurz closed this Aug 31, 2021
@SethTisue SethTisue removed this from the 2.12.15 milestone Aug 31, 2021
@SethTisue SethTisue removed the release-notes worth highlighting in next release notes label Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants