Fix specialization of methods with dependent return types#9652
Merged
lrytz merged 1 commit intoscala:2.13.xfrom Jun 2, 2021
Merged
Fix specialization of methods with dependent return types#9652lrytz merged 1 commit intoscala:2.13.xfrom
lrytz merged 1 commit intoscala:2.13.xfrom
Conversation
Substitute both type and value parameter symbols in return type
dwijnand
reviewed
Jun 2, 2021
| val substituter = new ImplementationAdapter(srcParams, newParams, source.enclClass, false) | ||
| val newRhs = substituter(body(source).duplicate) | ||
| tpt.modifyType(_.substSym(oldParams, newParams)) | ||
| copyDefDef(tree)(vparamss = newVparams.map(ValDef.apply) :: Nil, rhs = newRhs) |
Member
There was a problem hiding this comment.
I can't spot it after squinting a bit at it... where's the fix?
Member
Author
There was a problem hiding this comment.
In tpt.modifyType(_.substSym(oldParams, newParams)) where xParams = xVparams ::: xTparams - I've extracted the intermediate variables to make it more readable because it's confusing with 3 sets of parameters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Substitute both type and value parameter symbols in return type
Fixes scala/bug#12210