Add null check for getURLs-method#9588
Merged
dwijnand merged 1 commit intoscala:2.12.xfrom Apr 26, 2021
Merged
Conversation
Member
|
2.12 is good |
Member
|
review by @twometreshine? |
twometreshine
approved these changes
Apr 24, 2021
twometreshine
approved these changes
Apr 24, 2021
dwijnand
approved these changes
Apr 26, 2021
Member
|
thanks @Philippus (and @twometreshine for bringing the issue to our attention) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applying this PR will add a null check for when the getUrls-method returns
null. Fixes scala/bug#12376. I targeted scala 2.12, because the milestone of the bug is set to 2.12.14. If 2.13 is preferred I can rebase.