Recognize calls to generic Array.apply with primitive arguments in CleanUp#9544
Merged
lrytz merged 1 commit intoscala:2.13.xfrom Mar 25, 2021
Merged
Recognize calls to generic Array.apply with primitive arguments in CleanUp#9544lrytz merged 1 commit intoscala:2.13.xfrom
lrytz merged 1 commit intoscala:2.13.xfrom
Conversation
lrytz
reviewed
Mar 24, 2021
Member
lrytz
left a comment
There was a problem hiding this comment.
Thanks, this is looking good! Just a few small points.
Member
Author
|
@lrytz Would it be impertinent to ask, is this PR ready to merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Array[Double](1.0)targets the genericArray.applyoverload. This case was not handled by CleanUp and therefore not emitted as an array literal in bytecode.Fixes scala/bug#12201