Skip to content

Fix regression in repl printing#9526

Merged
lrytz merged 2 commits intoscala:2.12.xfrom
som-snytt:issue/12354
Mar 1, 2021
Merged

Fix regression in repl printing#9526
lrytz merged 2 commits intoscala:2.12.xfrom
som-snytt:issue/12354

Conversation

@som-snytt
Copy link
Contributor

Silence warnings until compiling code template.

Insert spaces in messages so quoted text aligns with the prompt line. (2.13 doesn't repeat the source text.)

Fixes scala/bug#12354

Silent parsing, then normal reporting when compiling template.

For silence, use method that restores settings when done.
@scala-jenkins scala-jenkins added this to the 2.12.14 milestone Feb 27, 2021
Copy link
Member

@dwijnand dwijnand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(seems to fix the original issue) ++ (none of the other tests broken) == LGTM

@lrytz
Copy link
Member

lrytz commented Mar 1, 2021

👍 thank you!

@lrytz lrytz merged commit 98d3781 into scala:2.12.x Mar 1, 2021
@som-snytt
Copy link
Contributor Author

Worth noting that the delta was small, but figuring out the reporter -- what is the metaphor? a rabbit warren? -- blew my time budget.

@som-snytt som-snytt deleted the issue/12354 branch March 1, 2021 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants