REPL: improve tab-completion of :-prefixed commands (fixes scala/bug#12264)#9521
Merged
SethTisue merged 1 commit intoscala:2.13.xfrom Mar 12, 2021
Merged
REPL: improve tab-completion of :-prefixed commands (fixes scala/bug#12264)#9521SethTisue merged 1 commit intoscala:2.13.xfrom
:-prefixed commands (fixes scala/bug#12264)#9521SethTisue merged 1 commit intoscala:2.13.xfrom
Conversation
:-prefixed commands (fixes scala/bug#12264)
Member
|
(sorry this is taking me so long to get to — I'm backlogged) |
Member
Author
hh |
Member
|
this LGTM — can you squash it into a single commit? then let's merge |
Member
Author
ok |
735d8c0 to
a2e187e
Compare
Member
|
excellent -- thank you! |
Contributor
|
The "organize imports" is extraneous. That is a matter of style, but in the absence of a project scalafix, I would avoid it as a rule. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Valid only for question mark commands. The question mark command has separate parsing logic and uses the Jline3 default parser. and Jline3 will parse it into
word:p. Jline3 usesprefixmatching orcontainsmatching, so:pcannot be matched to candidate, because the value of candidate ispasteandpower.The input and output of
: pcan be matched because thewordparsed by Jline3 isp, and it's collaborator think Jline3 is designed correctly. We should modify the candidate.