Skip to content

REPL: handle .inputrc#9518

Merged
SethTisue merged 1 commit intoscala:2.13.xfrom
jxnu-liguobin:fix-12269
Apr 21, 2021
Merged

REPL: handle .inputrc#9518
SethTisue merged 1 commit intoscala:2.13.xfrom
jxnu-liguobin:fix-12269

Conversation

@jxnu-liguobin
Copy link
Member

@jxnu-liguobin jxnu-liguobin commented Feb 23, 2021

@scala-jenkins scala-jenkins added this to the 2.13.6 milestone Feb 23, 2021
@dwijnand dwijnand changed the title Fixes scala/bug#12269 JLine 3: handle .inputrc Feb 23, 2021
@jxnu-liguobin

This comment has been minimized.

@SethTisue SethTisue self-requested a review March 9, 2021 18:35
@SethTisue SethTisue added the tool:REPL Changes to the Scala REPL shell label Mar 9, 2021
@SethTisue SethTisue changed the title JLine 3: handle .inputrc REPL: handle .inputrc Mar 9, 2021
@SethTisue
Copy link
Member

This is causing our OSGi tests to fail.

org.osgi.framework.BundleException: Unable to resolve org.scala-lang.scala-compiler [14](R 14.0): missing requirement [org.scala-lang.scala-compiler [14](R 14.0)] osgi.wiring.package; (osgi.wiring.package=org.jline.builtins) Unresolved requirements: [[org.scala-lang.scala-compiler [14](R 14.0)] osgi.wiring.package; (osgi.wiring.package=org.jline.builtins)]
	at org.apache.felix.framework.Felix.resolveBundleRevision(Felix.java:4149)
	at org.apache.felix.framework.Felix.startBundle(Felix.java:2119)
	at org.apache.felix.framework.Felix.setActiveStartLevel(Felix.java:1373)
	at org.apache.felix.framework.FrameworkStartLevelImpl.run(FrameworkStartLevelImpl.java:308)
	at java.lang.Thread.run(Thread.java:748)

Note that both Travis-CI and Jenkins are failing in the same way, and the failures are reproducible locally (with osgiTestFelix/test and osgiTestEclipse/test).

The clue seems to be osgi.wiring.package; (osgi.wiring.package=org.jline.builtins) — this PR adds import org.jline.builtins.InputRC

@jxnu-liguobin I have no real understanding of this stuff, but my guess is that what you need to do is add an org.jline.builtins entry to Osgi.headers in our build.sbt. Can you give that a try?

@SethTisue
Copy link
Member

Also while I'm here I just want to thank you for all these great PRs you're sending. You're on fire! 🔥

@jxnu-liguobin
Copy link
Member Author

@SethTisue I add it, but combined still failed, do I need attention?
btw, Thank you for your approval. I like Scala very much. I will continue.

@SethTisue
Copy link
Member

@SethTisue I add it, but combined still failed, do I need attention?

the scala/scala repo has an especially strict CI policy: every commit in a PR must be green, not just the last one. that's what "combined" is checking. So the problem will go away when you squash this into fewer commits.

btw, Thank you for your approval. I like Scala very much. I will continue.

❤️

@SethTisue
Copy link
Member

@retronym hey .inputrc guy — want to take this for a spin?

@SethTisue SethTisue added the release-notes worth highlighting in next release notes label Apr 21, 2021
@SethTisue SethTisue merged commit 996a89c into scala:2.13.x Apr 21, 2021
@SethTisue
Copy link
Member

SethTisue commented Apr 21, 2021

merged, but maybe there's somebody out there who would like to try a nightly and make sure it works on Windows?

@dwijnand dwijnand removed the release-notes worth highlighting in next release notes label May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tool:REPL Changes to the Scala REPL shell

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JLine 3: handle .inputrc?

4 participants