Conversation
This comment has been minimized.
This comment has been minimized.
57a4315 to
de79875
Compare
|
This is causing our OSGi tests to fail. Note that both Travis-CI and Jenkins are failing in the same way, and the failures are reproducible locally (with The clue seems to be @jxnu-liguobin I have no real understanding of this stuff, but my guess is that what you need to do is add an |
|
Also while I'm here I just want to thank you for all these great PRs you're sending. You're on fire! 🔥 |
|
@SethTisue I add it, but combined still failed, do I need attention? |
the scala/scala repo has an especially strict CI policy: every commit in a PR must be green, not just the last one. that's what "combined" is checking. So the problem will go away when you squash this into fewer commits.
❤️ |
|
@retronym hey |
d8c4f6c to
a6a9cbe
Compare
|
merged, but maybe there's somebody out there who would like to try a nightly and make sure it works on Windows? |
Fixes scala/bug#12269