Omit @nowarn annotations from generated code, for forwards compatibility at compile-time#9491
Merged
SethTisue merged 1 commit intoscala:2.13.xfrom Feb 18, 2021
Merged
Omit @nowarn annotations from generated code, for forwards compatibility at compile-time#9491SethTisue merged 1 commit intoscala:2.13.xfrom
@nowarn annotations from generated code, for forwards compatibility at compile-time#9491SethTisue merged 1 commit intoscala:2.13.xfrom
Conversation
...by special-casing them. In principle we have `extends Annotation` vs `extends StaticAnnotation` for that, but sadly `ConstantAnnotation extends StaticAnnotation`, so we don't get to choose for those :-/
@nowarn annotations...@nowarn annotations from generated code, for forwards compatibility
@nowarn annotations from generated code, for forwards compatibility@nowarn annotations from generated code, for forwards compatibility at compile-time
dwijnand
approved these changes
Feb 15, 2021
Member
dwijnand
left a comment
There was a problem hiding this comment.
LGTM. I guess we don't have the testing infra to simulate compiling with a different/older stdlib.
Member
|
@lrytz this should target 2.12.x, I think? won't 2.12.13 users be affected as well? |
Member
|
Lukas in team meeting: "We should backport it" to 2.12 |
Member
|
@lrytz I thought I'd take 1 minute to submit a backport but it isn't 1-minute job, the method you modified doesn't exist in 2.12. do you want to backport it, or shall I look into it next week? |
Member
Author
| would be the equivalent spot |
This was referenced Mar 12, 2021
This was referenced Mar 15, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...by special-casing them.
In principle we have
extends Annotationvsextends StaticAnnotationfor that, but sadly
ConstantAnnotation extends StaticAnnotation, sowe don't get to choose for those :-/
Fixes scala/bug#12336
(Note that the bug only caused problems at compile time, not at runtime)