Only look up the system prop controlling class tag caching once#9361
Merged
SethTisue merged 1 commit intoscala:2.12.xfrom Dec 4, 2020
Merged
Conversation
SethTisue
approved these changes
Dec 4, 2020
lrytz
approved these changes
Dec 4, 2020
Contributor
|
this also removed an allocation caused by |
Contributor
|
No one wondered why those |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a performance regression in the opt-out mechanism I added to #9276 but neglected to benchmark.
Prior to this PR (with the perf regression)
This PR:
With the
if (cacheDiabled)removed:The extra
if (cacheDisabled)now seems to have no significant performance cost, as we need.