Fix range position for vars with default initializer#9355
Merged
dwijnand merged 2 commits intoscala:2.12.xfrom Jan 18, 2021
Merged
Fix range position for vars with default initializer#9355dwijnand merged 2 commits intoscala:2.12.xfrom
dwijnand merged 2 commits intoscala:2.12.xfrom
Conversation
The `= _` should be include in the range position of the ValDef.
dwijnand
approved these changes
Dec 2, 2020
Member
|
a02ecf5 to
34453d5
Compare
Member
|
Looks like this definitely breaks |
Pass the position of the RHS explicitly rather than using `rhs.pos` within TreeBuilder, as that doesn't carry the position of the `_` represented by the singleton tree `EmptyTree`. Change the quasiquote parser to also pick up the change. Also, tweaks in DefinitionConstructionProps that came out of fixing the quasiquote parser change. Co-authored-by: Dale Wijnand <dale.wijnand@gmail.com>
34453d5 to
50c2bb7
Compare
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass the position of the RHS explicitly rather than using
rhs.poswithinTreeBuilder, as that doesn't carry the position of the
_represented bythe singleton tree
EmptyTree.Fixes scala/bug#12213