Catch exceptions for the InlineInfoAttribute reader#9325
Merged
retronym merged 2 commits intoscala:2.12.xfrom Nov 29, 2020
Merged
Catch exceptions for the InlineInfoAttribute reader#9325retronym merged 2 commits intoscala:2.12.xfrom
retronym merged 2 commits intoscala:2.12.xfrom
Conversation
som-snytt
reviewed
Nov 20, 2020
| } catch { | ||
| case ex: Exception => | ||
| if (frontendAccess.compilerSettings.debug) ex.printStackTrace() | ||
| backendReporting.warning(NoPosition, s"Error while reading InlineInfoAttribute from ${fullName}\n${ex.getMessage}") |
Contributor
There was a problem hiding this comment.
I haven't used this reporting, but maybe there is optimizerWarning so it uses the Optimizer category?
Contributor
Author
There was a problem hiding this comment.
The snippet for logging comes from PostProcessor
retronym
approved these changes
Nov 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes scala/bug#11247
Verified via
sbt publishLocalon this PR andsbt compileusing the snapshot Scala version on https://github.com/sadhen/bug_12229For logging:
And here is the logging tested (
"-Ydebug", "-Ylog:jvm"):