Restore Global.reporter()Reporter#9297
Conversation
It's an important binary API:
[scala-rewrites] [error] java.lang.NoSuchMethodError: scala.tools.nsc.Global.reporter()Lscala/tools/nsc/reporters/Reporter;
[scala-rewrites] [error] at scala.meta.internal.semanticdb.scalac.SemanticdbPlugin.init(SemanticdbPlugin.scala:25)
[scala-rewrites] [error] at scala.tools.nsc.plugins.Plugins.$anonfun$loadPlugins$9(Plugins.scala:162)
|
labeling with "internal" since the removal was never released |
|
To answer my own question "how did we get away with breaking this in 2.13?", the answer is "because there are no binary guarantees for scala-compiler" and I'm defiantly overriding that in scala-rewrites: https://github.com/scala/scala-rewrites/blob/aa3f71bfc16c342f14566db0a730a0516acafc7e/project/ScalaNightlyPlugin.scala#L26. In the community build both scala-compiler and scala-rewrites are compiled so if they compile together, why is it throwing a NoSuchMethodError? I think the cause is what this warning message is getting at:
Which is actually also documented at the top of the CB's proj/scala-rewrites.conf:
TL;DR this change wasn't as necessary as I'd thought. |
|
Undoing this: #9300. |
It's an important binary API: