Improve assertThrows, use it in NumericRangeTest#9106
Merged
lrytz merged 2 commits intoscala:2.13.xfrom Jul 9, 2020
Merged
Conversation
lrytz
reviewed
Jul 9, 2020
Member
lrytz
left a comment
There was a problem hiding this comment.
Thanks for spotting this! Will push a commit with some suggestions.
Contributor
Author
|
Thanks for your generous comment. I'd intended to get back to the problematic test, but I forgot to make it a draft PR. This is the sort of case where a student says they had a great teacher who made an encouraging remark instead of a mean comment that made them drop out of the program. |
Member
|
👆 this is the overly modest top scala/scala contributor who started off 8 years ago with a deep type checker patch and has not taken a break ever since |
Contributor
Author
|
@lrytz For extra credit, I will try to determine if this new test failure under Travis is for real. Apparently, it is a test I contributed, but then they deleted the comment that tells me what it does... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.