Skip to content

Improve assertThrows, use it in NumericRangeTest#9106

Merged
lrytz merged 2 commits intoscala:2.13.xfrom
som-snytt:issue/12073
Jul 9, 2020
Merged

Improve assertThrows, use it in NumericRangeTest#9106
lrytz merged 2 commits intoscala:2.13.xfrom
som-snytt:issue/12073

Conversation

@som-snytt
Copy link
Contributor

No description provided.

@scala-jenkins scala-jenkins added this to the 2.13.4 milestone Jul 8, 2020
@som-snytt som-snytt added the internal not resulting in user-visible changes (build changes, tests, internal cleanups) label Jul 8, 2020
Copy link
Member

@lrytz lrytz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this! Will push a commit with some suggestions.

@lrytz lrytz merged commit ee71608 into scala:2.13.x Jul 9, 2020
@som-snytt som-snytt deleted the issue/12073 branch July 9, 2020 15:06
@som-snytt
Copy link
Contributor Author

Thanks for your generous comment. I'd intended to get back to the problematic test, but I forgot to make it a draft PR.

This is the sort of case where a student says they had a great teacher who made an encouraging remark instead of a mean comment that made them drop out of the program.

@lrytz
Copy link
Member

lrytz commented Jul 10, 2020

👆 this is the overly modest top scala/scala contributor who started off 8 years ago with a deep type checker patch and has not taken a break ever since

@som-snytt
Copy link
Contributor Author

@lrytz For extra credit, I will try to determine if this new test failure under Travis is for real. Apparently, it is a test I contributed, but then they deleted the comment that tells me what it does...

scala.concurrent.FutureTest.bug$divissues$hash10513$u0020firstCompletedOf$u0020must$u0020not$u0020leak$u0020references failed: java.lang.AssertionError: Root Future(<not completed>) held reference java.lang.Object@3d785ff2, took 0.011 sec

[error]     at scala.tools.testkit.AssertUtil$.loop$2(AssertUtil.scala:138)

[error]     at scala.tools.testkit.AssertUtil$.$anonfun$assertNotReachable$5(AssertUtil.scala:148)

[error]     at scala.tools.testkit.AssertUtil$.$anonfun$assertNotReachable$5$adapted(AssertUtil.scala:144)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal not resulting in user-visible changes (build changes, tests, internal cleanups)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants