Respect -Xlint:-multiarg-infix to suppress lint at callsite#9089
Merged
lrytz merged 1 commit intoscala:2.13.xfrom Jun 29, 2020
Merged
Respect -Xlint:-multiarg-infix to suppress lint at callsite#9089lrytz merged 1 commit intoscala:2.13.xfrom
-Xlint:-multiarg-infix to suppress lint at callsite#9089lrytz merged 1 commit intoscala:2.13.xfrom
Conversation
lrytz
approved these changes
Jun 29, 2020
Member
lrytz
left a comment
There was a problem hiding this comment.
LGTM. The alternative would be to turn it into a deprecation, but multiarg-infix is not deprecated in dotty either (not even with -source:3.1).
-Xlint:-multiarg-infix
Member
|
(Feels like a too niche bug fix to be noteworthy to me...) |
-Xlint:-multiarg-infix-Xlint:multiarg-infix
Contributor
Author
|
The hyphen IIRC there was a warning difference between application and definition. |
Member
|
My point was it was always on (for applications or definitions) and it wouldn't respect a desire to switch it off, but I guess it was too terse to be communicate that clearly. |
-Xlint:multiarg-infix-Xlint:-multiarg-infix to suppress lint at callsite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes scala/bug#12058