Skip to content

A jar or zip must be a regular file#9034

Merged
lrytz merged 1 commit intoscala:2.13.xfrom
som-snytt:issue/12019
Jun 8, 2020
Merged

A jar or zip must be a regular file#9034
lrytz merged 1 commit intoscala:2.13.xfrom
som-snytt:issue/12019

Conversation

@som-snytt
Copy link
Contributor

Construct a test that creates a directory.zip
on the classpath for compilation. After Using it,
remove the directory.

Fixes scala/bug#12019

@scala-jenkins scala-jenkins added this to the 2.13.4 milestone Jun 3, 2020
@SethTisue SethTisue modified the milestones: 2.13.4, 2.13.3 Jun 4, 2020
@SethTisue
Copy link
Member

!!    1 - run/t11815.scala                          [output differs]
!!    2 - run/t6502.scala                           [output differs]

Construct a test that creates a directory.zip
on the classpath for compilation. After Using it,
remove the directory.
@som-snytt
Copy link
Contributor Author

Attempts to clarify the reflect.io API. Avoid implicit conversion from string for name test, e.g., for -d out.jar.

Distinguish Jar.isJarOrZip (tests an existing file) from Path.isExtensionJarOrZip (a name test).

Previously, isJarOrZip took a flag whether to probe the file header and only checked existence when probing.

@lrytz
Copy link
Member

lrytz commented Jun 8, 2020

Thank you!

@lrytz lrytz merged commit c5619f2 into scala:2.13.x Jun 8, 2020
@som-snytt som-snytt deleted the issue/12019 branch June 8, 2020 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scala compiler classpath gets confused by directory ending in .zip

4 participants