Fix StackOverflow in getParts cause by existential types#8990
Closed
joroKr21 wants to merge 1 commit intoscala:2.13.xfrom
Closed
Fix StackOverflow in getParts cause by existential types#8990joroKr21 wants to merge 1 commit intoscala:2.13.xfrom
joroKr21 wants to merge 1 commit intoscala:2.13.xfrom
Conversation
Existential types ruin structural equality. Luckily we don't care about the quantified variables except potentially their upper bounds for implicit scope. So we just instantiate them to their upper bounds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Existential types ruin structural equality.
Luckily we don't care about the quantified variables
except potentially their upper bounds for implicit scope.
So we just instantiate them to their upper bounds.