Avoid allocation of TreeInfo.Applied#8859
Merged
lrytz merged 1 commit intoscala:2.12.xfrom Apr 6, 2020
Merged
Conversation
While profiling a build I noticed that calls to disectApplied via `isSelfOrSuperConstrCall` was an allocation hotspot. These use cases only need to strip Apply/TypeApply, so in this commit I've duplicated a few lines of code to to this.
Member
Author
|
I hadn't seen this hotspot in previous compiler profiling. Perhaps that was because the JVM's escape analysis works in the setup we have in Perhaps Class Heirarchy Analysis marks I also marked I'd still propose we live with the small amount of code duplication ( |
Member
Author
|
/rebuild |
lrytz
approved these changes
Apr 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While profiling a build I noticed that calls to disectApplied
via
isSelfOrSuperConstrCallwas an allocation hotspot.These use cases only need to strip Apply/TypeApply, so in this
commit I've duplicated a few lines of code to to this.