Skip to content

No protected accessor when accessing through self type#8835

Merged
lrytz merged 1 commit intoscala:2.13.xfrom
lrytz:t11924
May 27, 2021
Merged

No protected accessor when accessing through self type#8835
lrytz merged 1 commit intoscala:2.13.xfrom
lrytz:t11924

Conversation

@lrytz
Copy link
Member

@lrytz lrytz commented Mar 27, 2020

@lrytz lrytz requested a review from retronym March 27, 2020 14:42
@scala-jenkins scala-jenkins added this to the 2.13.3 milestone Mar 27, 2020
lrytz
lrytz commented Mar 27, 2020
View reviewed changes
@lrytz
Copy link
Member Author

lrytz commented Apr 2, 2020 

[error] scala-reflect: Failed binary compatibility check against org.scala-lang:scala-reflect:2.13.0! Found 1 potential problems (filtered 271)
[error]  * abstract synthetic method scala$reflect$runtime$SynchronizedOps$SynchronizedBaseTypeSeq$$super$maxDepthOfElems()Int in interface scala.reflect.runtime.SynchronizedOps#SynchronizedBaseTypeSeq is present only in other version
[error]    filter with: ProblemFilters.exclude[ReversedMissingMethodProblem]("scala.reflect.runtime.SynchronizedOps#SynchronizedBaseTypeSeq.scala$reflect$runtime$SynchronizedOps$SynchronizedBaseTypeSeq$$super$maxDepthOfElems")

Heh, so the fix removed an unnecessary protected accessor

@SethTisue SethTisue modified the milestones: 2.13.3, 2.13.4 May 12, 2020
@SethTisue
Copy link
Member

SethTisue commented Oct 5, 2020 •
edited
Loading

@lrytz is this ready for review? want to suggest a reviewer?

(the merge conflict is just in the mima filters)

@lrytz
Copy link
Member Author

lrytz commented Oct 6, 2020

Yep, this is ready. Review by @retronym.

@dwijnand
Copy link
Member

dwijnand commented Oct 14, 2020

This needs a rebase. And a review/merge!

@lrytz lrytz force-pushed the t11924 branch 2 times, most recently from 592a4c4 to c7b66c4 Compare October 15, 2020 13:42
@dwijnand dwijnand modified the milestones: 2.13.4, 2.13.5 Oct 22, 2020
@SethTisue SethTisue modified the milestones: 2.13.5, 2.13.6 Feb 9, 2021
@SethTisue
Copy link
Member

SethTisue commented Apr 8, 2021

Rebased

@dwijnand dwijnand modified the milestones: 2.13.6, 2.13.7 May 10, 2021
@lrytz lrytz enabled auto-merge May 27, 2021 08:49
@lrytz lrytz merged commit 20ac944 into scala:2.13.x May 27, 2021
@lrytz lrytz mentioned this pull request Jun 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@retronym retronym retronym approved these changes

Assignees

@retronym retronym

Labels

None yet

Projects

None yet

Milestone

2.13.7

Development

Successfully merging this pull request may close these issues.

inconsistent logic when override self type method

5 participants

@lrytz @SethTisue @dwijnand @retronym @scala-jenkins