Skip to content

better diagnostics from AllocationTest#8825

Merged
retronym merged 1 commit intoscala:2.12.xfrom
mkeskells:2.12.x_AllocationTest
Apr 5, 2020
Merged

better diagnostics from AllocationTest#8825
retronym merged 1 commit intoscala:2.12.xfrom
mkeskells:2.12.x_AllocationTest

Conversation

@mkeskells
Copy link
Contributor

@mkeskells mkeskells commented Mar 24, 2020 •
edited
Loading

This doesn't change the general functionality much

  1. add an optional diagnostics text to the check
  2. option to ignore the equals check
  3. use of ClassTag rather than Manifest
  4. Introduce a sizeOf method to facilitate testing

the main change is when a test fails, so get a summary of the allocations, not one line for each of the 1000 failures

@scala-jenkins scala-jenkins added this to the 2.12.12 milestone Mar 24, 2020
@dwijnand dwijnand added the internal not resulting in user-visible changes (build changes, tests, internal cleanups) label Mar 25, 2020
@mkeskells mkeskells force-pushed the 2.12.x_AllocationTest branch 2 times, most recently from d50d9f6 to 506e62b Compare March 29, 2020 09:26
@mkeskells mkeskells force-pushed the 2.12.x_AllocationTest branch from 506e62b to a4da93b Compare March 29, 2020 14:15
@mkeskells mkeskells requested a review from retronym April 5, 2020 07:36
@retronym retronym merged commit 3be2f0d into scala:2.12.x Apr 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@retronym retronym retronym approved these changes

Assignees

No one assigned

Labels

internal not resulting in user-visible changes (build changes, tests, internal cleanups)

Projects

None yet

Milestone

2.12.12

Development

Successfully merging this pull request may close these issues.

4 participants

@mkeskells @retronym @dwijnand @scala-jenkins