Merged
Conversation
Back in the day, hoisting used to reduce allocations and classfile size; now it does the opposite. Clean up accordingly.
Contributor
|
@hrhino For my information, what has changed ever since? Is it a progress on the Scala compiler or on the JVM implementations? |
Contributor
Author
|
@diesalbla in 2.11-, lambdas desugared to (more or less) anonymous classes, so each use would create a new object. Now, lambdas use Java 8's LambdaMetaFactory, which caches a single lambda object at the call site if possible (i.e., the lambda expression doesn't capture any variables) and in either case doesn't require a new classfile per. |
diesalbla
approved these changes
Feb 29, 2020
Member
|
(let's wait on merging until after 2.12.11 is out the door) |
lrytz
approved these changes
Apr 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Back in the day, hoisting used to reduce allocations and classfile size; now it does the opposite. Clean up accordingly.