Skip to content

Basic TreeSet/TreeMap benchmark#8742

Merged
retronym merged 2 commits intoscala:2.12.xfrom
mkeskells:2.12.x_RedBlackBenckmark
Feb 26, 2020
Merged

Basic TreeSet/TreeMap benchmark#8742
retronym merged 2 commits intoscala:2.12.xfrom
mkeskells:2.12.x_RedBlackBenckmark

Conversation

@mkeskells
Copy link
Contributor

@mkeskells mkeskells commented Feb 22, 2020

@scala-jenkins scala-jenkins added this to the 2.12.12 milestone Feb 22, 2020
@diesalbla diesalbla added the library:collections PRs involving changes to the standard collection library label Feb 23, 2020
@mkeskells
Copy link
Contributor Author

mkeskells commented Feb 24, 2020

Sample commands are in comments on the benchmark. --prof gc if the bit that give the gc and allocation stats. Also I sometimes use --rf csv to get csv output for graphing and more detailed analysis

@szeiger
Copy link
Contributor

szeiger commented Feb 24, 2020

AFAIR the interface between RedBlackTree and TreeMap/TreeSet didn't really change with all the new algorithms and micro-optimizations I implemented in 2.13. It should be possible to use the 2.13 version in 2.12.

@SethTisue SethTisue added the internal not resulting in user-visible changes (build changes, tests, internal cleanups) label Feb 25, 2020
@mkeskells mkeskells force-pushed the 2.12.x_RedBlackBenckmark branch from bcfa00c to 393a0d5 Compare February 25, 2020 18:08
@mkeskells
Copy link
Contributor Author

mkeskells commented Feb 26, 2020

updated base benchmark in https://gist.github.com/mkeskells/76c6badb92a72c21f948990cee40b2ce

@mkeskells
Copy link
Contributor Author

mkeskells commented Feb 26, 2020

AFAIR the interface between RedBlackTree and TreeMap/TreeSet didn't really change with all the new algorithms and micro-optimizations I implemented in 2.13. It should be possible to use the 2.13 version in 2.12.

I will update #8749 to pull in the 2.13 tree and improved TreeSet/TreeMap API

@retronym retronym merged commit 4516efd into scala:2.12.x Feb 26, 2020
@SethTisue SethTisue modified the milestones: 2.12.12, 2.12.11 Feb 27, 2020
@lrytz lrytz added the performance the need for speed. usually compiler performance, sometimes runtime performance. label Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@retronym retronym retronym approved these changes

Assignees

No one assigned

Labels

internal not resulting in user-visible changes (build changes, tests, internal cleanups) library:collections PRs involving changes to the standard collection library performance the need for speed. usually compiler performance, sometimes runtime performance.

Projects

None yet

Milestone

2.12.11

Development

Successfully merging this pull request may close these issues.

7 participants

@mkeskells @szeiger @retronym @lrytz @SethTisue @scala-jenkins @diesalbla