Thoroughly typecheck Java sources for pickling#8692
Merged
retronym merged 1 commit intoscala:2.12.xfrom Feb 4, 2020
Merged
Conversation
Unlike .scala files, .java files are named and typed lazily: they will only be analyzed when necessary to typecheck a Scala source. However, under -Ypickle-java, pickler runs over them after typechecking, and can force infos that otherwise wouldn't be forced. If typing the Java source fails, the tree can contain erroneous types and symbols which will then crash pickler as it attempts to write out the pickle. This patch makes -Ypickle-java eagerly typecheck Java sources during typer, so any errors will be emitted alongside Scala typer errors. The enclosed test case previously crashed the compiler with a MatchError on ErrorType.
85dfec5 to
4099b6b
Compare
retronym
approved these changes
Feb 4, 2020
Member
retronym
left a comment
There was a problem hiding this comment.
Seems like a straight forward solution. The other possiblity would be to check for reporter.hasErrors after calling sym.info in putSymbol and bailing out of that phase, but that seems more fragile.
Contributor
Author
|
Thanks. That was my first go but then you have to bail on the first error (or buffer them somehow) whereas this hopefully lets you get all of the Java errors that we can detect |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unlike
.scalafiles,.javafiles are named and typed lazily: they will only be analyzed when necessary to typecheck a Scala source. However, under-Ypickle-java,picklerruns over them after typechecking, and can force infos that otherwise wouldn't be forced. If typing the Java source fails, the tree can contain erroneous types and symbols which will then crashpickleras it attempts to write out the pickle.This patch makes
-Ypickle-javaeagerly typecheck Java sources duringtyper, so any errors will be emitted alongside Scala typer errors.The enclosed test case previously crashed the compiler with a
MatchErroronErrorType.