Merged
Conversation
The `last` of the concat chain advances when the tail is consumed and last is the tailhead; and when the current ConcatIterator is lifted and its tail assumed, maybe also assume its last.
Member
|
target 2.12.x? |
Contributor
Seen in #8550. Thank you! |
diesalbla
reviewed
Nov 25, 2019
szeiger
approved these changes
Nov 27, 2019
Contributor
szeiger
left a comment
There was a problem hiding this comment.
With all the code getting moved around it's hard to see the actual difference but the one I spotted looks reasonable and the tests confirm that it works.
Contributor
Author
|
The backport has only the second commit, which is the functional fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
lastof the concat chain advanceswhen the tail is consumed and last is the tailhead;
and when the current ConcatIterator is lifted
and its tail assumed, maybe also assume its last.
Fixes scala/bug#11807