add testing for status quo of Byte and Short toHexString#8383
Merged
lrytz merged 2 commits intoscala:2.13.xfrom Mar 17, 2021
Merged
add testing for status quo of Byte and Short toHexString#8383lrytz merged 2 commits intoscala:2.13.xfrom
lrytz merged 2 commits intoscala:2.13.xfrom
Conversation
Contributor
Author
|
Mima rose to her feet in the overheated courtroom and though her throat had gone dry managed to say in a voice that sounded very far away to her own ear but which seized the amazement of everyone in attendance:
|
lrytz
reviewed
Sep 25, 2019
c373ef2 to
a94fb4f
Compare
Contributor
Author
|
Requires conditional compilation! |
Contributor
Author
|
I'll reopen if 2.14 or 3.2, whichever comes first. |
Contributor
Author
|
See scala/scala-library-next#49 which may or may not supersede this. |
Contributor
Author
|
Reopening this for improved test. |
Document sign extension in conversion to int for purposes of enrichment. Similarly for toOctalString and toBinaryString.
a94fb4f to
f81e1a9
Compare
SethTisue
approved these changes
Mar 16, 2021
Contributor
Author
|
I had changed the title to "Byte and Short stuck with sign-extended toHexString", but I lost internet around 3 a.m. thx comcast. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid sign extension in conversion to int forpurposes of enrichment.
Similarly for toOctalString and toBinaryString.references scala/bug#10216