Use the first scalac-plugin.xml from the plugin classpath#8345
Merged
retronym merged 1 commit intoscala:2.12.xfrom Aug 19, 2019
Merged
Use the first scalac-plugin.xml from the plugin classpath#8345retronym merged 1 commit intoscala:2.12.xfrom
retronym merged 1 commit intoscala:2.12.xfrom
Conversation
This commit reverts part of the scala#8322 I recently changed to using the last entry from getResources to avoid parent classloader delegation, but this leads to unwanted results if the plugin classpath itself contains multiple `scalac-plugin.xml` resources and wants the compiler to choose the first. I have _not_ reverted the other change in scala#8322 which overrides `getResource` to avoid parent delegation for `scalac-plugin.xml`. I have documented the `findPluginClassLoader` extension point with instructions to do the same.
Contributor
|
I guess it is too soon to mention |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit reverts part of #8322
I recently changed to using the last entry from getResources to
avoid parent classloader delegation, but this leads to unwanted
results if the plugin classpath itself contains multiple
scalac-plugin.xmlresources and wants the compiler to choosethe first.
I have not reverted the other change in #8322 which overrides
getResourceto avoid parent delegation forscalac-plugin.xml.I have documented the
findPluginClassLoaderextension pointwith instructions to do the same.