Escape dollar signs for variables in doc comments#8290
Merged
lrytz merged 1 commit intoscala:2.12.xfrom Aug 16, 2019
Merged
Conversation
Member
Author
|
This should merge forward to 2.13 with no problem, but you can verify with: Once merged to 2.13, there are more to fix (e.g. partest and new collections). |
som-snytt
approved these changes
Aug 1, 2019
Contributor
som-snytt
left a comment
There was a problem hiding this comment.
Thanks, those were my examples in Regex.
Member
|
Thank you! |
This was referenced Aug 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A lot of warnings are emitted for undefined variables. For example: