Fixes for windows regressions in classfile writing#8233
Merged
retronym merged 1 commit intoscala:2.12.xfrom Jul 17, 2019
Merged
Fixes for windows regressions in classfile writing#8233retronym merged 1 commit intoscala:2.12.xfrom
retronym merged 1 commit intoscala:2.12.xfrom
Conversation
som-snytt
reviewed
Jul 16, 2019
som-snytt
reviewed
Jul 16, 2019
1d8441a to
8238f5d
Compare
My refactoring to use nio.file.Path to represent relative paths was wrong-headed -- it is too easy to call .toString and get the system default file separator in places where we actually really want a '/'. Also fix regression in t5717 test on Windows
Member
Contributor
|
Yay. I felt bad that some poor test I quote-unquote contributed in 2013 cost folks some time, over time. |
Member
|
0.001% of our gratitude for your contributions is CANCELED! |
Contributor
|
For some reason, I didn't remember this for #8539 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes scala/scala-dev#638