Optimize check for by-name expressions#8231
Merged
lrytz merged 1 commit intoscala:2.12.xfrom Jul 16, 2019
Merged
Conversation
Rule out some cases by the type of tree of flags before looking at the symbol's info.
lrytz
reviewed
Jul 16, 2019
| def isByNameRef(tree: Tree) = ( | ||
| tree.isTerm | ||
| && (tree.symbol ne null) | ||
| && !(tree.symbol.hasPackageFlag || tree.isInstanceOf[This] || tree.isInstanceOf[Super]) |
Member
There was a problem hiding this comment.
Could we narrow it down to tree.isInstanceOf[Ident]?
Member
Author
There was a problem hiding this comment.
Nope, by-name types flow through generics, so can currently turn up in Select-s as well. There are some existing partest that rely on this.
It's a pretty murky area of the spec/implementation, so I chose a blacklist rather than a whitelist here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rule out some cases by the type of tree / flags before
looking at the symbol's info.