[SUPERSEDED] Insert stabilizers at definitions#8208
Closed
som-snytt wants to merge 1 commit intoscala:2.13.xfrom
Closed
[SUPERSEDED] Insert stabilizers at definitions#8208som-snytt wants to merge 1 commit intoscala:2.13.xfrom
som-snytt wants to merge 1 commit intoscala:2.13.xfrom
Conversation
Member
|
rebased |
Contributor
Author
|
I'll get back to this. |
Don't blow through definitions looking for a suitable context to insert stabilizers. If the definition happens to be a valdef, stick the attachments with stabilizers to the RHS, which must be the maximal expression getting typechecked.
Contributor
Author
|
Lukas got back to this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes commits from the related PR.
An alternative implementation might be to use the "synthetics" mechanism, where the synthetic is created and then subsequently emitted together with its sibling code. This mechanism wants to be improved, so that the synthetic is more directly tied to its source tree.
This PR tries to be minimal change.
Fixes scala/bug#11609