Skip to content

Windows compat for PipelineMainTest, finally?#8153

Merged
retronym merged 2 commits intoscala:2.12.xfrom
retronym:topic/windows-pipeline-test
Jun 19, 2019
Merged

Windows compat for PipelineMainTest, finally?#8153
retronym merged 2 commits intoscala:2.12.xfrom
retronym:topic/windows-pipeline-test

Conversation

@retronym
Copy link
Member

@retronym retronym commented Jun 16, 2019 •
edited
Loading

@scala-jenkins scala-jenkins added this to the 2.12.9 milestone Jun 16, 2019
@SethTisue SethTisue self-assigned this Jun 16, 2019
@retronym
Copy link
Member Author

retronym commented Jun 16, 2019 •
edited
Loading

A different failure this time:

[error] Test scala.tools.nsc.PipelineMainTest.pipelineMainBuildsJavaAccessor failed: java.nio.file.FileSystemException: y:\jenkins\tmp\pipelineBase7627402723219031974\projects\b5\p1\target\b5.p1.args: The process cannot access the file because it is being used by another process.

[error] , took 0.233 sec
[error]     at sun.nio.fs.WindowsException.translateToIOException(WindowsException.java:86)
[error]     at sun.nio.fs.WindowsException.rethrowAsIOException(WindowsException.java:97)
[error]     at sun.nio.fs.WindowsException.rethrowAsIOException(WindowsException.java:102)
[error]     at sun.nio.fs.WindowsFileSystemProvider.implDelete(WindowsFileSystemProvider.java:269)

Trying another change to close the .args file after reading.

@retronym
Copy link
Member Author

retronym commented Jun 17, 2019 •
edited
Loading

Oh great, now I've made Windows work but Unix is broken.

�[0m[�[31merror�[0m] �[0mTest scala.tools.nsc.�[33mPipelineMainTest�[0m.�[31mpipelineMainBuildsSeparate�[0m failed: java.lang.�[31mAssertionError�[0m: assertion failed: Difference detected between recompiling Pipeline Run:�[0m
�[0m[�[31merror�[0m] �[0mjardiff -r /tmp/pipelineBase6362677336303277836/Traditional/classes /tmp/pipelineBase6362677336303277836/Pipeline/classes�[0m
�[0m[�[31merror�[0m] �[0m, took 6.362 sec�[0m
�[0m[�[31merror�[0m] �[0m    at scala.tools.nsc.FileUtils$.assertDirectorySame(FileUtils.scala:11)�[0m
�[0m[�[31merror�[0m] �[0m    at scala.tools.nsc.PipelineMainTest.$anonfun$check$3(�[35mPipelineMainTest.scala�[0m:�[33m76�[0m)�[0m
�[0m[�[31merror�[0m] �[0m    at scala.tools.nsc.PipelineMainTest.check(�[35mPipelineMainTest.scala�[0m:�[33m71�[0m)�[0m
�[0m[�[31merror�[0m] �[0m    at scala.tools.nsc.PipelineMainTest.pipelineMainBuildsSeparate(�[35mPipelineMainTest.scala�[0m:�[33m36�[0m)�[0m

@SethTisue SethTisue removed their assignment Jun 17, 2019
martin-g
martin-g reviewed Jun 17, 2019
View reviewed changes
src/compiler/scala/tools/nsc/CompilerCommand.scala
import collection.JavaConverters._
val file = Paths.get(arg stripPrefix "@")
if (!Files.exists(file))
throw new java.io.FileNotFoundException("argument file %s could not be found" format file)
Copy link

@martin-g martin-g Jun 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just curious: any reason why you prefer String#format() than String interpolation ?

Copy link
Member Author

@retronym retronym Jun 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was minimizing the diff, but String interpolation would be fine here as well.

@SethTisue SethTisue added the internal not resulting in user-visible changes (build changes, tests, internal cleanups) label Jun 18, 2019
@retronym retronym merged commit 00343bc into scala:2.12.x Jun 19, 2019
@retronym
Copy link
Member Author

retronym commented Jun 20, 2019

Just saw the flaky test failure in PipelineMainTest again in another PR. Tracking as scala/scala-dev#637

@SethTisue
Copy link
Member

SethTisue commented Jun 20, 2019 •
edited
Loading

learn to code, they said. programming is fun, they said.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@martin-g martin-g martin-g left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

internal not resulting in user-visible changes (build changes, tests, internal cleanups)

Projects

None yet

Milestone

2.12.9

Development

Successfully merging this pull request may close these issues.

4 participants

@retronym @SethTisue @martin-g @scala-jenkins