Awaitable.result should have a throws annotation of TimeoutException and InterruptedException as well as Awaitable.ready #8143
Merged
SethTisue merged 1 commit intoscala:2.12.xfrom Jun 18, 2019
takayahilton:awaitable-result-throws
Merged
Awaitable.result should have a throws annotation of TimeoutException and InterruptedException as well as Awaitable.ready #8143SethTisue merged 1 commit intoscala:2.12.xfrom takayahilton:awaitable-result-throws
SethTisue merged 1 commit intoscala:2.12.xfrom
takayahilton:awaitable-result-throws
Conversation
…and InterruptedException as well as Awaitable.ready.
Contributor
|
Since the @throws-annotations are primarily for Java users, this change would be a breaking change, would it not? |
Member
|
Yeah, source-breaking for Java users. |
Member
|
or not source-breaking, since merging regardless, it's okay to break source in this way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.