fix 11551. use == instead of equals in BitmapIndexedSetNode#8117
Merged
adriaanm merged 1 commit intoscala:2.13.xfrom Jun 3, 2019
Merged
fix 11551. use == instead of equals in BitmapIndexedSetNode#8117adriaanm merged 1 commit intoscala:2.13.xfrom
adriaanm merged 1 commit intoscala:2.13.xfrom
Conversation
hrhino
approved these changes
Jun 2, 2019
Contributor
|
What I don't understand is why that change fixes anything (and/or why it was broken in the first place). |
Member
|
I've tentatively put this on a new 2.13.0 milestone, since it seems like something that could mergeable without a further RC. @adriaanm will make the final call |
Member
|
@NthPortal you need to pick to either use equals and hashCode and ignore collaborative equality/hashing (which is faster but some things are "weird"), or you use |
joshlemer
approved these changes
Jun 2, 2019
Contributor
|
oh oops - I didn't notice that one was |
Contributor
|
Let's ship this in 2.13.0. Thank you, @xuwei-k! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix scala/bug#11551