Fix scalap parsing/printing of enum and class constant types#8066
Merged
lrytz merged 1 commit intoscala:2.12.xfrom May 17, 2019
Merged
Fix scalap parsing/printing of enum and class constant types#8066lrytz merged 1 commit intoscala:2.12.xfrom
lrytz merged 1 commit intoscala:2.12.xfrom
Conversation
retronym
commented
May 17, 2019
| final val ClassConstant: java.lang.Class[scala.Predef.String] = { /* compiled code */ } | ||
| final val ClassConstant2: java.lang.Class[scala.Some[_]] = { /* compiled code */ } | ||
| final val EnumConstant: java.util.concurrent.TimeUnit = { /* compiled code */ } | ||
| final val StringConstant: java.lang.Class[scala.Predef.String] = { /* compiled code */ } |
Member
Author
There was a problem hiding this comment.
Strictly speaking, scalap should render these methods as final val IntConstant = 1, rather than with the widened type. But I'm only here on a drive-by fix and just want to avoid the crash that stops jardiff from comparing the signatures in scala/concurrent/duration/package.class.
retronym
commented
May 17, 2019
| 34 -^ null, | ||
| 35 -~ typeRef) | ||
| 35 -~ typeRef, | ||
| 36 -~ symbolRef |
Member
Author
Member
There was a problem hiding this comment.
more annotations cleanup.
Great commit message for a +159 -194 commit 😂
lrytz
approved these changes
May 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes scala/bug#5194