Cleanups around caching of classpath/classloaders#8021
Merged
retronym merged 2 commits intoscala:2.12.xfrom May 9, 2019
Merged
Cleanups around caching of classpath/classloaders#8021retronym merged 2 commits intoscala:2.12.xfrom
retronym merged 2 commits intoscala:2.12.xfrom
Conversation
Member
|
Kind of surprising to see you use pattern matching over |
Cancel in-progress timer task on a cache hit. This avoids reducing the effective deferred close delay when the old timer task fires and sees a ref count of zero, even though the ref count has since been positive.
7b628db to
e4406b9
Compare
Member
Author
|
/cc @smarter |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve timer-based eviction of classloader caches
Cancel in-progress timer task on a cache hit. This avoids reducing the
effective deferred close delay when the old timer task fires and sees a ref
count of zero, even though the ref count has since been positive.
Remove unused, duplicated copy of findMacroClassLoader