correct jansi version in intellij setup#7999
Merged
SethTisue merged 1 commit intoscala:2.12.xfrom May 4, 2019
Merged
Conversation
Member
Author
|
hmm I see that even https://repo1.maven.org/maven2/jline/jline/2.14.6/jline-2.14.6.jar has the shaded jansi in it, so it's probably better to just remove this entry from the IntelliJ project? |
Member
Author
|
someone can take up my removal question separately if they want |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure the jansi entry ought to be here at all,
since the jline 1.14.6 jar embeds it shaded, but all
the weird jline stuff in our build.sbt makes me unsure.
but anyway, I happened to notice that the version number was wrong, as
per https://github.com/jline/jline2/blob/jline-2.14.6/pom.xml#L122 ,
having it right can't be bad