[SUPERSEDED] Deprecate lower case long literal like you mean it#7388
[SUPERSEDED] Deprecate lower case long literal like you mean it#7388som-snytt wants to merge 3 commits intoscala:2.13.xfrom
Conversation
|
half of me wants to say "awesome, cool, thanks!", but the other half wants to say this would probably better be handled by an external linting tool. @som-snytt wdyt? is there an argument to be made that it belongs in this codebase? |
|
The argument for xlinting The argument to mitigate the error on leading zero is that octal syntax is no longer a thing. Unwinding the error is a scalac change; whether to retain any warning for purposes of migration is a coin toss, as its purpose is to alert people who use octal syntax and need to be warned that they mistakenly used it intentionally in scala. Arguably the onus is on scala for ever supporting it. |
that sounds appealing |
|
Try it, you'll like it. The new warning-filtering reporting system will make it easy to ignore, in case you are using your favorite password in code: |
6ef466c to
9d086c4
Compare
Don't put the `1l` warning behind a flag. Deprecation is already somewhat behind a flag, and the new warning-filtering reporter will make it easy to suppress it, and the new scalafix will make it easy to correct it.
9d086c4 to
7e26ca0
Compare
|
@SethTisue there were tricky Lukas tests with |
|
On the other numeric literal PR, I was like, I thought leading zero didn't error anymore. Well, it's hung up in this PR, which ought to be an easy win. Go team! Win! Win! Win! Edit: oh right, I split this off from the other PR, figuring that half of a no-brainer should be twice as easy. |
Rebased from #6989