Skip to content

fix jvm/strictfp checkfile now that compiler is deterministic#7377

Merged
SethTisue merged 1 commit intoscala:2.12.xfrom
hrhino:shame
Oct 30, 2018
Merged

fix jvm/strictfp checkfile now that compiler is deterministic#7377
SethTisue merged 1 commit intoscala:2.12.xfrom
hrhino:shame

Conversation

@hrhino
Copy link
Contributor

@hrhino hrhino commented Oct 30, 2018

No description provided.

@SethTisue
Copy link
Member

I'm confused, was there a platform-specific issue here, or wasn't there? if it was passing before on Linux, won't it start failing now? I guess let's see what the PR validator says. we can also do a https://scala-ci.typesafe.com/job/scala-2.13.x-integrate-windows/ run before merging, for good measure

@hrhino
Copy link
Contributor Author

hrhino commented Oct 30, 2018

That would be nice. I believe the problem was (as Adriaan mentioned) that this went in before the compiler determinism PR, so platform issues could affect the names of synthetic methods that used a fresh name creator.

FWIW, the test case (before this change) was passing on my Mac when I made the earlier PR, and now fails, with the exact same system configuration.

@SethTisue SethTisue merged commit f4975a8 into scala:2.12.x Oct 30, 2018
@SethTisue
Copy link
Member

(the same failure also turned up on another PR, so that removes any doubt this was a semantic merge conflict rather than a platform-specific issue)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants