[#11123] fix for equality of WrappedArray.ofRef#7156
Merged
szeiger merged 3 commits intoscala:2.12.xfrom Sep 7, 2018
Merged
Conversation
xuwei-k
reviewed
Aug 31, 2018
| override def hashCode = MurmurHash3.wrappedArrayHash(array) | ||
| override def equals(that: Any) = that match { | ||
| case that: ofRef[_] => Arrays.equals(array.asInstanceOf[Array[AnyRef]], that.array.asInstanceOf[Array[AnyRef]]) | ||
| case that: ofRef[_] => that.array.canEqual(array) && array.sameElements(that.array) |
Contributor
There was a problem hiding this comment.
I think that.array.canEqual(array) is always return true.
Contributor
Author
There was a problem hiding this comment.
Seq(1) == Seq(1.0) also invokes canEqual in IterableLike which always returns true.
This code snippet is taken from GenSeqLike's equals.
Well, since it always yields true, I should remove it.
Contributor
|
Welcome, @sadhen! Thanks for the prompt fix. I'd like to give Stefan a chance to take a look before merging this (he's on vacation this week). |
szeiger
suggested changes
Sep 6, 2018
szeiger
approved these changes
Sep 7, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes scala/bug#11123