Skip to content

Revert linting until restarr#7069

Merged
SethTisue merged 1 commit intoscala:2.13.xfrom
som-snytt:issue/revert-linting
Aug 15, 2018
Merged

Revert linting until restarr#7069
SethTisue merged 1 commit intoscala:2.13.xfrom
som-snytt:issue/revert-linting

Conversation

@som-snytt
Copy link
Contributor

The linting will be more reasonably verbose in future.

The linting will be more reasonably verbose in future.
@scala-jenkins scala-jenkins added this to the 2.13.0-RC1 milestone Aug 14, 2018
This was referenced Aug 14, 2018
@SethTisue SethTisue modified the milestones: 2.13.0-RC1, 2.13.0-M5 Aug 15, 2018
@SethTisue SethTisue merged commit 4ce94b8 into scala:2.13.x Aug 15, 2018
@som-snytt som-snytt deleted the issue/revert-linting branch August 15, 2018 23:47
@SethTisue
Copy link
Member

we have now re-STARRed

@SethTisue
Copy link
Member

@som-snytt did you mean to return to this?

@som-snytt
Copy link
Contributor Author

I think I accidentally left linting turned on in a PR somewhere, but I don't remember where.

@SethTisue
Copy link
Member

@som-snytt should we uncomment these lines, or delete them, or what?

@som-snytt
Copy link
Contributor Author

@SethTisue Does my commented code bug you? It's to save me 5-10 minutes every time I forget that maxErrors thing in sbt, which I remember now only because someone mentioned it recently.

Probably I did turn on the linting in a PR, but it was never merged.

I'm working on a debugging SIP called Meta-Optimized Operational Records for Scala, or MOORS, which we can use as inline pragmas instead of println and Xlint. A MOORS directive will print information about a value, including the git blame of the line that set it. -Xmax-blame does that for all lines that contribute to a calculation. -Yassign reduces the problem to only lines touched by retronym, so the ticket can be assigned directly to him.

@som-snytt
Copy link
Contributor Author

Moors' Law: When you flip the switches back again, the errors will have increased exponentially:

[error] scala.reflect.internal.FatalError: object Predef does not have a member $eq$colon$eq
[error] 	at scala.reflect.internal.Definitions$DefinitionsClass.fatalMissingSymbol(Definitions.scala:1338)

@som-snytt
Copy link
Contributor Author

@SethTisue I see it's because of df29ebb in #7350

It needs another restarr?

@som-snytt
Copy link
Contributor Author

I confirmed that the linked PR went in after the last restarr, so building with diagnostics on crashes non-bootstrapped as above. Maybe there is a way to enable diagnostic options only when running a bootstrapped build? That would make it less useful, of course, since warnings would appear only in Jenkins output where Jenkins would politely ignore the mess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants