Skip to content

fix t7668 test case on Windows#7024

Merged
SethTisue merged 1 commit intoscala:2.13.xfrom
SethTisue:fix-7768-test-on-windows
Aug 8, 2018
Merged

fix t7668 test case on Windows#7024
SethTisue merged 1 commit intoscala:2.13.xfrom
SethTisue:fix-7768-test-on-windows

Conversation

@SethTisue
Copy link
Member

@SethTisue SethTisue commented Aug 8, 2018

in posh British accent: "CON you call something CON on Windows? No, you CONnot."

references #6037

CON you call something CON on Windows? No, you CONnot.

references scala#6037
@scala-jenkins scala-jenkins added this to the 2.13.0-RC1 milestone Aug 8, 2018
@SethTisue SethTisue modified the milestones: 2.13.0-RC1, 2.13.0-M5 Aug 8, 2018
@SethTisue SethTisue self-assigned this Aug 8, 2018
@SethTisue SethTisue merged commit a32527e into scala:2.13.x Aug 8, 2018
@SethTisue SethTisue deleted the fix-7768-test-on-windows branch August 8, 2018 21:00
@dwijnand
Copy link
Member

dwijnand commented Aug 8, 2018

RIP alignment.

Also: looks like partest is silent in failing to create the classfile, which could be improved.

@martijnhoekstra
Copy link
Contributor

@dwijnand is there a ticket for that? If not, it's all but certain to not be picked up

@dwijnand
Copy link
Member

dwijnand commented Aug 9, 2018

No, I was just putting it out there. Do you think it's worrisome?

@martijnhoekstra
Copy link
Contributor

@dwijnand like you said, it probably could be improved. Things that help hunting down partest cross-compat bugs are nice - not having to guess at what's gong wrong/which part has bitrotted but being pointed in the right direction is also nice.

@smarter
Copy link
Member

smarter commented Aug 9, 2018

I think scalac should just forbid emitting files whose names are illegal under Windows: https://stackoverflow.com/a/31976060/348497
As an aside, the same root cause once brought down the cargo registry: http://sasheldon.com/blog/2017/05/07/how-i-broke-cargo-for-windows/

@SethTisue
Copy link
Member Author

this limitation/bug is from 1974: https://twitter.com/Foone/status/1058676834940776450

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants